Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tl;dr: I made a quick test with adding colors to the attributes test, making a pull request in case it is of interest just to share my hacking :)
It's just a quick test (e.g. I didn't bother adding labels to the fore- and background selectors), so it probably would need some adjustments in that regard at least.
Also took the liberty of adding a
settings.jsonwhich sets the spelling language to British English (en_GB) on a hunch based on the ".uk" link on your profile (went with the spelling "colour" in the source based on that guess too).This branch basically adds two combo-boxes for choosing the fore- and background color of the text, and a checkbox whether to combine that with the other attributes or not. The colors are the basic "ISO colors" for the SGR rage 30-37,39 (and 4x ditto).
However I didn't implement 256-color or RGB truecolor support. (Which ironically what was I was originally fiddling with in combination with the bold attr.)
So, in other words feel free to do as you please with it.